Protobuf general update #1175
Merged
Protobuf general update #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
2 times, most recently
from
4db5a4d to
5ca21b1
Compare
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
from
5ca21b1 to
cd8b61a
Compare
|
I worked around the issue about the missing |
|
The compilation is failing due to protobuf-c/protobuf-c#699 |
|
@AlessandroBono is this ready? |
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
2 times, most recently
from
2cb6fe1 to
3a29d2b
Compare
1 task
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
from
3a29d2b to
aa63046
Compare
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
from
aa63046 to
0cba765
Compare
Yes this is ready. |
Closes: wingtk#1174
Add abseil-cpp as a dependency. It is required since version 22.0 (aka 3.22.0)[1] [1] protocolbuffers/protobuf@a9f1ea6
Add abseil-cpp as a dependency since it is now required. Furthermore: - add Config.cmake.in file[1] because it is missing from the tarball; - add a proposed patch[2] to fix the build with cmake. [1] protobuf-c/protobuf-c#698 [2] protobuf-c/protobuf-c#699
AlessandroBono
force-pushed
the
wip/abono/protobuf
branch
from
0cba765 to
b2c24c8
Compare
nacho
approved these changes
Dec 4, 2024
|
Nice! do you have a PR for the patch you made for protobuf-c? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as Draft since the build of
protobuf-c1.5.0 still fails. See protobuf-c/protobuf-c#698